fix(systemtags): remove duplicates, cleanup existing tags#56079
Merged
Conversation
f8eaffa to
6e099a3
Compare
skjnldsv
commented
Oct 29, 2025
e30d0af to
5ceb404
Compare
5ceb404 to
7927592
Compare
artonge
reviewed
Oct 29, 2025
CarlSchwan
reviewed
Oct 29, 2025
b659742 to
19aa6fc
Compare
Member
Author
|
Ok @artonge and @CarlSchwan I think I addressed most of the performance issues. |
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
Merged
Closed
a8b7c7c to
70d0c06
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Assisted-by: ClaudeCode:claude-opus-4-8
CarlSchwan
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some tags can be created with empty whitespace or
\tor\r... etcThis leads to confusion on the handling of tags.
Details
Important
Testing
Here is a SQL script to populate the tables with fake data (click to expand)
- Sanitize and merge duplicate system tags - Starting sanitization of system tags... - Found 21 tags with 10 unique sanitized names. - WARNING: Cannot merge tag group 'Confidential': tags have different visibility or editable settings. Manual verification required. Tag IDs: 9, 8, 7 - Merged tags [17, 16, 15] into ID 14 (sanitized: 'ToDo') - Merged tags [3, 2] into ID 1 (sanitized: 'Important') - WARNING: Cannot merge tag group 'Archive': tags have different visibility or editable settings. Manual verification required. Tag IDs: 11, 10 - Merged tags [19] into ID 18 (sanitized: 'Internal') - Sanitized tag ID 13: 'Meeting Notes ' → 'Meeting Notes' - Merged tags [21] into ID 20 (sanitized: 'Popular') - Sanitized tag ID 12: 'Project Alpha ' → 'Project Alpha' - Merged tags [6] into ID 4 (sanitized: 'Urgent') - System tag sanitization and merge completed.Checklist
3. to review, feature component)stable32)